Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves java developer experience with WfRunVariable assignments, de… #1076

Merged
merged 22 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b4feb50
improves java developer experience with WfRunVariable assignments, de…
coltmcnealy-lh Oct 29, 2024
e0e1f70
linter
coltmcnealy-lh Oct 30, 2024
56f58a0
fixes from testing
coltmcnealy-lh Oct 30, 2024
d7236db
adds the Expression proto object
coltmcnealy-lh Nov 14, 2024
bfa18bc
allows creating Expressions in the java sdk
coltmcnealy-lh Nov 15, 2024
6e20972
Merge branch 'master' into feat/java-sdk-variable-improvements
coltmcnealy-lh Nov 20, 2024
aed166d
adds not-so-working example
coltmcnealy-lh Nov 20, 2024
c957f40
revert example changes
coltmcnealy-lh Nov 20, 2024
f945991
fixes default case on a switch
coltmcnealy-lh Nov 21, 2024
de93fd6
tmp progress
coltmcnealy-lh Nov 21, 2024
c293a9c
Merge branch 'master' into feat/java-sdk-variable-improvements
coltmcnealy-lh Nov 22, 2024
3135047
Merge branch 'master' into feat/java-sdk-variable-improvements
coltmcnealy-lh Nov 25, 2024
4a77668
adds failing tests
coltmcnealy-lh Nov 25, 2024
ff33861
more tests
coltmcnealy-lh Nov 25, 2024
61a3dd6
closer to passing the tests
coltmcnealy-lh Nov 25, 2024
5a50494
tests pass im gonna go to sleep now
coltmcnealy-lh Nov 25, 2024
a2cc355
Merge branch 'master' into feat/java-sdk-variable-improvements
coltmcnealy-lh Nov 25, 2024
888b3a6
more tests and they pass now
coltmcnealy-lh Nov 25, 2024
57c8e9b
Merge branch 'master' into feat/java-sdk-variable-improvements
coltmcnealy-lh Nov 25, 2024
e363a3e
fixes javadoc
coltmcnealy-lh Nov 25, 2024
7fbcbdb
asdfasfdjpalk
coltmcnealy-lh Nov 25, 2024
e1e23a1
removes incorrect test
coltmcnealy-lh Nov 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions docs/docs/08-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,22 @@ have to worry about this in daily LittleHorse usage.
| `literal_value` | oneof `source`| [VariableValue](#variablevalue) | Assign a literal value |
| `format_string` | oneof `source`| [VariableAssignment.FormatString](#variableassignmentformatstring) | Assign a format string |
| `node_output` | oneof `source`| [VariableAssignment.NodeOutputReference](#variableassignmentnodeoutputreference) | Assign the value of a NodeOutput. |
| `expression` | oneof `source`| [VariableAssignment.Expression](#variableassignmentexpression) | Assign the value of an Expression. |
<!-- end Fields -->
<!-- end HasFields -->



### Message `VariableAssignment.Expression` {#variableassignmentexpression}

An Expression allows you to combine multiple values into one.


| Field | Label | Type | Description |
| ----- | ---- | ---- | ----------- |
| `lhs` | | [VariableAssignment](#variableassignment) | The left-hand-side of the expression. |
| `operation` | | [VariableMutationType](#variablemutationtype) | The operator in the expression. |
| `rhs` | | [VariableAssignment](#variableassignment) | The right-hand-side of the expression. |
<!-- end Fields -->
<!-- end HasFields -->

Expand Down
12 changes: 12 additions & 0 deletions schemas/littlehorse/common_wfspec.proto
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ message VariableAssignment {
string node_name = 1;
}

// An Expression allows you to combine multiple values into one.
message Expression {
// The left-hand-side of the expression.
VariableAssignment lhs = 1;
// The operator in the expression.
VariableMutationType operation = 2;
// The right-hand-side of the expression.
VariableAssignment rhs = 3;
}

// If you provide a `variable_name` and the specified variable is JSON_OBJ or
// JSON_ARR type, then you may also provide a json_path which makes the VariableAssignment
// resolve to the specified field.
Expand All @@ -54,6 +64,8 @@ message VariableAssignment {
FormatString format_string = 4;
// Assign the value of a NodeOutput.
NodeOutputReference node_output = 5;
// Assign the value of an Expression.
Expression expression = 6;
}
}

Expand Down
523 changes: 320 additions & 203 deletions sdk-go/lhproto/common_wfspec.pb.go

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading