refactor(dashboard): tenant cookie -> dynamic route slug #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a warning on the server about RocksDB if you have `earliestStart` undefined & `latestStart` as `Date.now()`
|
@sauljabin @coltmcnealy-lh This will help us with detecting metrics for each tenant. |
really good catch, yes |
hazimoarafa
force-pushed
the
refactor-tenant-slug
branch
from
1ae1c7b to
0eaa35e
Compare
hazimoarafa
force-pushed
the
refactor-tenant-slug
branch
from
0eaa35e to
bd5d3b4
Compare
hazimoarafa
force-pushed
the
refactor-tenant-slug
branch
3 times, most recently
from
61ce019 to
e047bdc
Compare
hazimoarafa
force-pushed
the
refactor-tenant-slug
branch
from
e047bdc to
8983d4b
Compare
hazimoarafa
force-pushed
the
refactor-tenant-slug
branch
from
8983d4b to
a241471
Compare
hazimoarafa
force-pushed
the
refactor-tenant-slug
branch
from
c8f7e18 to
7cb08ee
Compare
hazimoarafa
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
You had some missing hrefs that needed to be updated with the new [tenantId] url so I went ahead and fixed everything.
Also for future reference tenantId when being used in the code should be coming from the URL not from whoamI context or the cookie. I have already fixed that as well
| import getWhoAmI from './getWhoami' | ||
|
|
||
| export default async function Home() { | ||
| const whoAmI = await getWhoAmI() |
There was a problem hiding this comment.
I was thinking why not do this in middleware but yes Next.js doesn't support node apis in middleware.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1137
[tenantId]dynamic routetenantIdto the passedhrefprop.defaulttenantIdwithinnext.config.mjsredirect&hrefis accounted for with the new route to maintain functionality