Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): standardize on variableassignment for mutations #1164

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

coltmcnealy-lh
Copy link
Member

  • Deprecates the literal_value and node_output options of VariableMutation.rhs_value
  • Updates sdk-java to only use the VariableAssignment field
  • Renames VariableMutation.source_variable to VariableMutation.rhs_assignment

- Deprecates the literal_value and node_output options of VariableMutation.rhs_value
- Updates sdk-java to only use the VariableAssignment field
- Renames VariableMutation.source_variable to VariableMutation.rhs_assignment
Copy link
Member

@eduwercamacaro eduwercamacaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@HazimAr HazimAr force-pushed the refactor/sdk-java-var-mutations branch from 7347844 to de2eb21 Compare November 26, 2024 05:38
Copy link
Member

@HazimAr HazimAr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard LGTM!

@coltmcnealy-lh
Copy link
Member Author

Dashboard LGTM!

Thanks for the assist, Captain Hooah.

@coltmcnealy-lh coltmcnealy-lh merged commit 06ed297 into master Nov 26, 2024
15 of 16 checks passed
@coltmcnealy-lh coltmcnealy-lh deleted the refactor/sdk-java-var-mutations branch November 26, 2024 05:46
Snarr added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants