Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Pass UserTask User details to WorkerContext #1178

Merged
merged 9 commits into from
Dec 5, 2024
Merged

fix(server): Pass UserTask User details to WorkerContext #1178

merged 9 commits into from
Dec 5, 2024

Conversation

Snarr
Copy link
Member

@Snarr Snarr commented Dec 4, 2024 •
edited
Loading

This PR makes sure that UserTask User details are passed onto the WorkerContext when necessary by fixing a bug in the UserTaskTriggerReferenceModel where we failed to serialize the userId and userGroup.

This PR also adds 2 E2E tests:

  • 1 covering functionality for Scheduled Reminder Tasks
  • 1 covering functionality for passing UserTask User details to the WorkerContext.

@Snarr Snarr changed the title fix(server): Use Optionals for optional UserTaskTriggerReference fields fix(server): Check for Null for optional UserTaskTriggerReference fields Dec 4, 2024
@Snarr Snarr changed the title fix(server): Check for Null for optional UserTaskTriggerReference fields fix(server): Pass UserTask User details to WorkerContext Dec 4, 2024
@KarlaCarvajal KarlaCarvajal self-requested a review December 4, 2024 22:32
KarlaCarvajal
KarlaCarvajal approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@KarlaCarvajal KarlaCarvajal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Snarr Snarr merged commit 4a534db into master Dec 5, 2024
16 checks passed
@Snarr Snarr deleted the fix/server/optional-utt-reference-fields branch December 5, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlaCarvajal KarlaCarvajal KarlaCarvajal approved these changes

@eduwercamacaro eduwercamacaro Awaiting requested review from eduwercamacaro

@coltmcnealy-lh coltmcnealy-lh Awaiting requested review from coltmcnealy-lh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Snarr @KarlaCarvajal