feat(dashboard): display scheduledWfRuns #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a table would be great idea not only for scheduled Wfs but just normal |
hazimoarafa
requested changes
Dec 17, 2024
dashboard/src/app/[tenantId]/(diagram)/wfSpec/[...props]/actions/getScheduleWfSpec.ts
Outdated
Show resolved
Hide resolved
dashboard/src/app/[tenantId]/(diagram)/wfSpec/[...props]/components/WfRuns.tsx
Outdated
Show resolved
Hide resolved
…horse-enterprises/littlehorse into dashboard-scheduledwfruns
|
Looks like lh-standalone broke, please fix. |
hazimoarafa
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1087
Description
WfSpecs&ScheduledWfSpecs.SelectionLinkcomponent used forWfSpeclist &ScheduledWfSpecfor consistent design.ScheduledWfSpecs, since proto buff does not support queries. -SearchScheduledWfRunRequest should support querying for pagination #1201ScheduledWfSpecsby time window for next expected run datetime.Considerations
ScheduledWfRuns, such as by the cron expression categories themselves.ScheduledWfRun, in which case a table UI would be good:https://ui.shadcn.com/docs/components/data-table
Videos
Before
Screen.Recording.2024-12-16.at.3.56.01.PM.mov
After
Screen.Recording.2024-12-16.at.4.03.49.PM.mov