Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): large variable display #1213

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

bryson-g
Copy link
Contributor

@bryson-g bryson-g commented Dec 18, 2024

resolves #866

Description

  • Created Overflow component which can be used anywhere to truncate and display full text on click w/ modal
    • This component auto-formats JSON, and perhaps we will want to support other formats like YAML
  • Created CopyButton component used for copying text to clipboard
  • Created TS logic for dynamic rendering of text on WfRun's variables section
    • Variables that overflow show new Overflow component, while text within bounds appears normal

Video & Screenshot

Before

image

After

Screen.Recording.2024-12-17.at.8.18.19.PM.mov

@bryson-g bryson-g requested a review from hazimoarafa December 18, 2024 04:42
@bryson-g bryson-g changed the title Dashboard large variables display feat(dashboard): large variable display Dec 18, 2024
@bryson-g bryson-g requested a review from hazimoarafa December 20, 2024 02:28
@bryson-g bryson-g force-pushed the dashboard-large-variables-display branch from a367906 to b6b3424 Compare December 20, 2024 03:09
@bryson-g bryson-g force-pushed the dashboard-large-variables-display branch from b6b3424 to c4c1c48 Compare December 20, 2024 03:17
@bryson-g bryson-g merged commit 3a51fbb into master Dec 20, 2024
17 checks passed
@bryson-g bryson-g deleted the dashboard-large-variables-display branch December 20, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show large variable values like YMLs
2 participants