Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dashboard): show logOutput #1217

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

bryson-g
Copy link
Contributor

resolves #1215

Description

  • Displays logOutput, if it exists, or falls back on the more generic nodeRun.errorMessage.
    • Displays one or the other, instead of both at once. LMK if this is good. (Maybe controversial)x
  • OverflowText variant prop for consistent styling.
    • Added error variant.

Screenshots

Before

image

After

image image

@bryson-g bryson-g force-pushed the dashboard-log-output branch from 167f75d to 5243276 Compare December 20, 2024 09:39
@bryson-g bryson-g requested a review from HazimAr December 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaskRun error message should appear in View NodeRuns modal
2 participants