Make CI,ci0 in example non-degenerate to RowMajor / ColMajor #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example in
src/main.cc
(accidentally) works even if matrices are passed in column major order instead of QuadProg++'s expected row major order.H
is symmetric so under doesn't matter. Likewise,CE
is 1x1. ButCI
is a rectangular matrix and passing its entries in the wrong order (withci0
left as is), will produce a correct result. As a result I got this example running and then assumed QuadProg++ was using Column Major ordering (doh!).Not sure many people will run into the same issue as me, but just in case: here's a tiny fix that simply permutes the order of the constraints in
CI
andci0
in the example so that using column major will not produce the same result (and in fact will make the problem infeasible).