Bugfixes with multicodec simulcast #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidzhao
commented
Sep 1, 2023
davidzhao
commented
- No longer require explicit settings in BackupVideoCodec
- Fix crashes when backupCodec isn't set
- Avoid using default settings, instead use the track's publication options
- Correctly set SVC codec layers
* Avoid using default settings, instead use the track's publication options * Correctly set SVC codec layers
|
There's one remaining issue, which is when AV1 is used, the publisher's connection quality is marked POOR. This doesn't happen when no subscriber is in the room. |
Yes, I have observed this, but the ConnectionQualityInfo seems to be sent by SFU, is it possible that the server is not calculating the AV1 quality accurately? When I received the POOR, the publisher reported from rtcStats that the total sending bit rate was about 2500kbps. 
and the subscribers show POOR quality even when they are subscribing with good quality 
|
Parfyonator
pushed a commit
to Parfyonator/client-sdk-flutter
that referenced
this pull request
Sep 4, 2023
* Attempt to simplify example app * * Fix crashes when backupCodec isn't set * Avoid using default settings, instead use the track's publication options * Correctly set SVC codec layers * fix import_sorter. * fix flutter analyzer. --------- Co-authored-by: cloudwebrtc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.