Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix captureScreenAudio conditional #378

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Fix captureScreenAudio conditional #378

merged 1 commit into from
Oct 8, 2023

Conversation

kNoAPP
Copy link
Contributor

@kNoAPP kNoAPP commented Oct 8, 2023

Expected
When I pass false to captureScreenAudio, an audio track should not be created/published to the LiveKit room.

Actual
Whenever captureScreenAudio is not null, an audio track is always created/published to the LiveKit room regardless of if the variable is false or not.

Fix
Updated the captureScreenAudio conditional to default to false if the variable is null. Otherwise the actual true/false value is used for the conditional.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cloudwebrtc
cloudwebrtc approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cloudwebrtc cloudwebrtc merged commit 07ff78c into livekit:main Oct 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kNoAPP @CLAassistant @cloudwebrtc