fix: low-resolution screen sharing for safari 17. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasIO
reviewed
Oct 17, 2023
| // Remove resolution settings to fix low-resolution screen share on Safari 17. | ||
| // related bug: https://bugs.webkit.org/show_bug.cgi?id=263015 | ||
| if (lkBrowser() == BrowserType.safari && | ||
| lkBrowserVersion().major == 17) { |
There was a problem hiding this comment.
good thinking to specifically fix it for this Safari version, too.
I think we should do something similar on the JS side.
The bugreport in webkit only talks about width: { max: constraints. maybe width: { ideal: would be possible as a workaround for Safari 17.
I remember it not being a valid workaround in general because ideal was causing issues in other Safari versions :/
There was a problem hiding this comment.
just tested using width: { ideal:, doesn't seem to fix it, I still get the low resolution screen capture :(
if (lkBrowser() == BrowserType.safari &&
lkBrowserVersion().major == 17) {
constraints['video'] = {
'width': {'ideal': options.params.dimensions.width},
'height': {'ideal': options.params.dimensions.height},
};
}There was a problem hiding this comment.
thanks for checking. then your fix seems like the best option :)
lukasIO
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related fix on js livekit/client-sdk-js#889