Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: video rendering flickers for safari. #388

Closed
wants to merge 3 commits into from
Closed

fix: video rendering flickers for safari. #388

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eccf9b
fix: video rendering flickers for safari.
cloudwebrtc Oct 23, 2023
7dc614f
update.
cloudwebrtc Oct 23, 2023
77b56cf
Merge branch 'main' into fix/video-rendering-flickers
cloudwebrtc Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions example/lib/pages/room.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ class _RoomPageState extends State<RoomPage> {
@override
void initState() {
super.initState();
// add callback for a `RoomEvent` as opposed to a `ParticipantEvent`
widget.room.addListener(_onRoomDidUpdate);
// add callbacks for finer grained events
_setUpListeners();
_sortParticipants();
Expand Down Expand Up @@ -86,11 +84,6 @@ class _RoomPageState extends State<RoomPage> {
WidgetsBindingCompatible.instance?.addPostFrameCallback(
(timeStamp) => Navigator.popUntil(context, (route) => route.isFirst));
})
..on<ParticipantEvent>((event) {
print('Participant event');
// sort participants on many track events as noted in documentation linked above
_sortParticipants();
})
..on<RoomRecordingStatusChanged>((event) {
context.showRecordingStatusChangedDialog(event.activeRecording);
})
Expand Down Expand Up @@ -153,10 +146,6 @@ class _RoomPageState extends State<RoomPage> {
}
}

void _onRoomDidUpdate() {
_sortParticipants();
}

void _onE2EEStateEvent(TrackE2EEStateEvent e2eeState) {
print('e2ee state: $e2eeState');
}
Expand Down
Loading