Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/unpublish screen audio when stop screen share #389

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Fix/unpublish screen audio when stop screen share #389

merged 9 commits into from
Oct 26, 2023

Conversation

cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc commented Oct 25, 2023 •
edited
Loading

  • Unpublish the screen audio track when stopping screen sharing.
  • Listen for MediaStreamTrack.ended to unpublish itself.

close #379

@cloudwebrtc cloudwebrtc force-pushed the fix/unpublish-screen-audio-when-stop-screen-share branch from e8ad32c to 96fe986 Compare October 25, 2023 01:36
@cloudwebrtc cloudwebrtc marked this pull request as ready for review October 25, 2023 02:12
@cloudwebrtc cloudwebrtc merged commit c24053b into main Oct 26, 2023
7 checks passed
@cloudwebrtc cloudwebrtc deleted the fix/unpublish-screen-audio-when-stop-screen-share branch October 26, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao Awaiting requested review from davidzhao

@hiroshihorie hiroshihorie Awaiting requested review from hiroshihorie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] Capturing external screen-share cancel event
1 participant
@cloudwebrtc