Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed confusing room options causing settings to overwrite. #570

Merged
merged 12 commits into from
Aug 9, 2024
Merged

fix: Fixed confusing room options causing settings to overwrite. #570

merged 12 commits into from
Aug 9, 2024

Conversation

cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc commented Aug 8, 2024 •
edited
Loading

changes:
Remove connectOptions from Room constructor,
Remove roomOptions from room.connect
Copy encoding from defaultCameraCaptureOptions/defaultScreenShareCaptureOptions when videoPublishOptions.videoEncoding is null

@cloudwebrtc cloudwebrtc marked this pull request as ready for review August 8, 2024 11:59
@cloudwebrtc cloudwebrtc requested a review from davidzhao August 8, 2024 12:00
davidzhao
davidzhao reviewed Aug 9, 2024
View reviewed changes
example/lib/pages/prejoin.dart Outdated Show resolved Hide resolved
lib/src/core/room.dart Show resolved Hide resolved
lib/src/participant/local.dart Outdated Show resolved Hide resolved
lib/src/types/video_parameters.dart Outdated Show resolved Hide resolved
@cloudwebrtc cloudwebrtc requested a review from davidzhao August 9, 2024 05:24
davidzhao
davidzhao reviewed Aug 9, 2024
View reviewed changes
lib/src/utils.dart Outdated Show resolved Hide resolved
lib/src/utils.dart Outdated Show resolved Hide resolved
@cloudwebrtc cloudwebrtc requested a review from davidzhao August 9, 2024 05:49
davidzhao
davidzhao approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@cloudwebrtc cloudwebrtc merged commit 05800e7 into main Aug 9, 2024
7 of 8 checks passed
@cloudwebrtc cloudwebrtc deleted the fix/confusion-room-options branch August 9, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudwebrtc @davidzhao