Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle disconnect reasons correctly. #594

Merged
merged 2 commits into from
Sep 22, 2024
Merged

fix: Handle disconnect reasons correctly. #594

merged 2 commits into from
Sep 22, 2024

Conversation

cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc commented Sep 22, 2024 •
edited
Loading

davidzhao
davidzhao reviewed Sep 22, 2024
View reviewed changes
lib/src/core/engine.dart Outdated Show resolved Hide resolved
davidzhao
davidzhao approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cloudwebrtc cloudwebrtc merged commit c9a0560 into main Sep 22, 2024
8 checks passed
@cloudwebrtc cloudwebrtc deleted the fix/handle-room-deleted-and-state-mismatch branch September 22, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] room_started is trigger after room_finished on client.deleteRoom
2 participants
@cloudwebrtc @davidzhao