Proto to "report" different kinds of data. #962
Conversation
Starting off with `FeatureUsage` with the one feature od `KRISP_NOISE_CANCELLATION`.
🦋 Changeset detectedLatest commit: 0ef8aed The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
| string participant_id = 6; | ||
| string track_id = 7; | ||
| google.protobuf.Timestamp started_at = 8; | ||
| google.protobuf.Timestamp ended_at = 9; |
There was a problem hiding this comment.
A couple of notes/questions
AnalyticsEventmessage has a bunch of common fields likeroom_id,track_id, but I am making this standalone message fully self-contained. Is that okay?- Talking about self-contained, this only has
room_name,room_id,participant_identityandparticipant_idand it does not have fullRoomorParticipantInfo. Is that okay? If full objects are needed, will have to get clients to submit it as the controller handling the report will not have all context.
| @@ -121,8 +121,9 @@ enum AnalyticsEventType { | |||
| SIP_CALL_INCOMING = 37; | |||
| SIP_CALL_STARTED = 38; | |||
| SIP_CALL_ENDED = 39; | |||
| REPORT = 40; | |||
There was a problem hiding this comment.
Adding an AnalyticsEvent to report different kinds of data to analytics. Open to a better name.
| @@ -202,3 +204,24 @@ message AnalyticsNodeRooms { | |||
| google.protobuf.Timestamp timestamp = 3; | |||
| repeated AnalyticsRoom rooms = 4; | |||
| } | |||
|
|
|||
| message ReportInfo { | |||
There was a problem hiding this comment.
Container for Report event data. Starting off a FeatureUsage to report Krisp usage.
| } | ||
| } | ||
|
|
||
| message FeatureUsageInfo { |
There was a problem hiding this comment.
Making a generic feature usage message with an enum to indicate which feature. Thinking there will be more feature usage reports in the feature. So, made a generic FeatureUsage container with an enum.
Co-authored-by: lukasIO <[email protected]>
Starting off with
FeatureUsagewith the one feature odKRISP_NOISE_CANCELLATION.