-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ai): complete retryable sessions after current request #3414
fix(ai): complete retryable sessions after current request #3414
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3414 +/- ##
===================================================
+ Coverage 32.08870% 32.09666% +0.00796%
===================================================
Files 147 147
Lines 40949 40970 +21
===================================================
+ Hits 13140 13150 +10
- Misses 27032 27043 +11
Partials 777 777
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 2 inline comments. Other than that, LGTM
@leszko updates are complete. Should be good to merge when checks complete. |
What does this pull request do? Explain your changes. (required)
Update
processAIRequest
to add sessions back to selector after the current request if errors are retryable.Replaces #3400 and includes update for LiveVideoToVideo in #3407.
Specific updates (required)
Complete
on when the request ends. LiveVideoToVideo will add insufficient capacity errors back to selector on next refreshHow did you test each of these updates (required)
Built docker image and sent batch AI request until 503 unavailable error returned. Pulled /getAISessionPoolsInfo to confirm 1 orchestrator not suspended
Does this pull request close any open issues?
No
Checklist:
make
runs successfully./test.sh
pass