Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai): complete retryable sessions after current request #3414

Merged

Conversation

ad-astra-video
Copy link
Collaborator

@ad-astra-video ad-astra-video commented Feb 23, 2025

What does this pull request do? Explain your changes. (required)

Update processAIRequest to add sessions back to selector after the current request if errors are retryable.

Replaces #3400 and includes update for LiveVideoToVideo in #3407.

Specific updates (required)

  • Adds sessions that have retryable errors to list to call Complete on when the request ends. LiveVideoToVideo will add insufficient capacity errors back to selector on next refresh

How did you test each of these updates (required)

Built docker image and sent batch AI request until 503 unavailable error returned. Pulled /getAISessionPoolsInfo to confirm 1 orchestrator not suspended

Does this pull request close any open issues?

No

Checklist:

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Feb 23, 2025
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 32.09666%. Comparing base (3765073) to head (91d5786).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_process.go 52.38095% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3414         +/-   ##
===================================================
+ Coverage   32.08870%   32.09666%   +0.00796%     
===================================================
  Files            147         147                 
  Lines          40949       40970         +21     
===================================================
+ Hits           13140       13150         +10     
- Misses         27032       27043         +11     
  Partials         777         777                 
Files with missing lines Coverage Δ
server/ai_process.go 1.48026% <52.38095%> (+0.89449%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3765073...91d5786. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_process.go 1.48026% <52.38095%> (+0.89449%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 inline comments. Other than that, LGTM

@ad-astra-video
Copy link
Collaborator Author

@leszko updates are complete. Should be good to merge when checks complete.

@leszko leszko merged commit 7c9d1cd into livepeer:master Feb 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants