优化cast array语法的解析逻辑 alibaba#5894

lizongbo · May 9, 2024 · d4ce0fa · d4ce0fa
1 parent e08e92e
commit d4ce0fa
Show file tree

Hide file tree

Showing 4 changed files with 57 additions and 1 deletion.
diff --git a/core/src/main/java/com/alibaba/druid/sql/ast/SQLArrayDataType.java b/core/src/main/java/com/alibaba/druid/sql/ast/SQLArrayDataType.java
@@ -14,6 +14,7 @@ public class SQLArrayDataType extends SQLObjectImpl implements SQLDataType {
 
     private DbType dbType;
     private SQLDataType componentType;
+    private boolean usedForCast;
     private List<SQLExpr> arguments = new ArrayList<SQLExpr>();
 
     public SQLArrayDataType(SQLDataType componentType) {
@@ -55,6 +56,14 @@ public void setWithTimeZone(Boolean value) {
         throw new UnsupportedOperationException();
     }
 
+    public boolean isUsedForCast() {
+        return usedForCast;
+    }
+
+    public void setUsedForCast(boolean usedForCast) {
+        this.usedForCast = usedForCast;
+    }
+
     @Override
     public boolean isWithLocalTimeZone() {
         return false;

diff --git a/core/src/main/java/com/alibaba/druid/sql/parser/SQLExprParser.java b/core/src/main/java/com/alibaba/druid/sql/parser/SQLExprParser.java
@@ -947,6 +947,13 @@ public SQLExpr primary() {
                     accept(Token.AS);
                     cast.setDataType(
                             parseDataType(false));
+                    if (cast.getDataType() instanceof SQLArrayDataType) {
+                        SQLArrayDataType arrayDataType = (SQLArrayDataType) cast.getDataType();
+                        if (arrayDataType.getDbType() == null) {
+                            arrayDataType.setDbType(dbType);
+                        }
+                        arrayDataType.setUsedForCast(true);
+                    }
                     accept(Token.RPAREN);
 
                     sqlExpr = cast;

diff --git a/core/src/main/java/com/alibaba/druid/sql/visitor/SQLASTOutputVisitor.java b/core/src/main/java/com/alibaba/druid/sql/visitor/SQLASTOutputVisitor.java
@@ -9499,7 +9499,10 @@ public boolean visit(SQLArrayDataType x) {
             print(']');
         } else {
             SQLDataType componentType = x.getComponentType();
-            if (componentType != null) {
+            if (x.isUsedForCast() && componentType != null && componentType.getArguments() != null && componentType.getArguments().size() > 0) {
+                componentType.accept(this);
+                print0(ucase ? " ARRAY" : " array");
+            } else if (componentType != null) {
                 print0(ucase ? "ARRAY<" : "array<");
                 componentType.accept(this);
                 print('>');

diff --git a/core/src/test/java/com/alibaba/druid/bvt/sql/mysql/issues/Issue5894.java b/core/src/test/java/com/alibaba/druid/bvt/sql/mysql/issues/Issue5894.java
@@ -0,0 +1,37 @@
+package com.alibaba.druid.bvt.sql.mysql.issues;
+
+import java.util.List;
+
+import com.alibaba.druid.DbType;
+import com.alibaba.druid.sql.SQLParseAssertUtil;
+import com.alibaba.druid.sql.ast.SQLStatement;
+import com.alibaba.druid.sql.parser.SQLParserUtils;
+import com.alibaba.druid.sql.parser.SQLStatementParser;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * @author lizongbo
+ * @see <a href="https://github.com/alibaba/druid/issues/5894>Issue来源</a>
+ * @see <a href="https://dev.mysql.com/doc/refman/8.0/en/cast-functions.html#function_cast">CAST(expr AS type [ARRAY])</a>
+ */
+public class Issue5894 {
+
+    @Test
+    public void test_parse_aschararray() {
+        for (DbType dbType : new DbType[]{DbType.mysql}) {
+            for (String sql : new String[]{
+                "alter table db1.rs_push_mall_data add key idx_bill_no_json((CAST(bill_no_json AS CHAR(50) ARRAY)));",
+            }) {
+                SQLStatementParser parser = SQLParserUtils.createSQLStatementParser(sql, dbType);
+                List<SQLStatement> statementList = parser.parseStatementList();
+                assertEquals(1, statementList.size());
+                assertEquals("ALTER TABLE db1.rs_push_mall_data\n"
+                    + "\tADD KEY idx_bill_no_json (CAST(bill_no_json AS CHAR(50) ARRAY));", statementList.get(0).toString());
+                SQLParseAssertUtil.assertParseSql(sql, dbType);
+            }
+        }
+    }
+}