Optimize split string

myframe/common.cpp

@@ -109,14 +109,21 @@ bool Common::IsAbsolutePath(const std::string& path) {
   return false;
 }
 
-std::vector<std::string> Common::SplitMsgName(const std::string& name) {
-  std::vector<std::string> name_list;
-  std::string item;
-  std::stringstream ss(name);
-  while (std::getline(ss, item, '.')) {
-    name_list.push_back(std::move(item));
+std::vector<std::string_view> Common::SplitMsgName(const std::string& name) {
+  std::vector<std::string_view> tokens;
+  tokens.reserve(3);
+  size_t name_sz = name.size();
+  size_t start_pos = 0;
+  for (size_t i = 0; i < name_sz; ++i) {
+    if (name[i] == '.') {
+      tokens.emplace_back(&name[start_pos], i - start_pos);
+      start_pos = i + 1;
+    }
+    if (i == name_sz - 1) {
+      tokens.emplace_back(&name[start_pos], i - start_pos + 1);
+    }
   }
-  return name_list;
+  return tokens;
 }
 
 }  // namespace myframe

myframe/common.h

@@ -10,6 +10,7 @@ Author: 李柯鹏 <[email protected]>
 #include <memory>
 #include <string>
 #include <vector>
+#include <string_view>
 #if __has_include(<filesystem>)
 #include <filesystem>
 namespace stdfs = std::filesystem;
@@ -31,7 +32,7 @@ class MYFRAME_EXPORT Common final {
   static stdfs::path GetAbsolutePath(const std::string& flag_path);
   static bool IsAbsolutePath(const std::string& path);
 
-  static std::vector<std::string> SplitMsgName(const std::string& name);
+  static std::vector<std::string_view> SplitMsgName(const std::string& name);
 };
 
 }  // namespace myframe