Optimize find

lkpworkspace · Jul 4, 2024 · b5b967a · b5b967a
1 parent ce8d9cd
commit b5b967a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/myframe/actor_context_manager.cpp b/myframe/actor_context_manager.cpp
@@ -54,12 +54,12 @@ bool ActorContextManager::RegContext(std::shared_ptr<ActorContext> ctx) {
 std::shared_ptr<ActorContext> ActorContextManager::GetContext(
     const std::string& actor_name) {
   std::shared_lock<std::shared_mutex> lk(rw_);
-  if (ctxs_.find(actor_name) == ctxs_.end()) {
+  auto p = ctxs_.find(actor_name);
+  if (p == ctxs_.end()) {
     LOG(WARNING) << "not found " << actor_name;
     return nullptr;
   }
-  auto ctx = ctxs_[actor_name];
-  return ctx;
+  return p->second;
 }
 
 std::vector<std::string> ActorContextManager::GetAllActorAddr() {

diff --git a/myframe/event_manager.cpp b/myframe/event_manager.cpp
@@ -26,10 +26,11 @@ EventManager::~EventManager() {
 
 ev_handle_t EventManager::ToHandle(const std::string& name) {
   std::shared_lock<std::shared_mutex> lk(rw_);
-  if (name_handle_map_.find(name) == name_handle_map_.end()) {
+  auto p = name_handle_map_.find(name);
+  if (p == name_handle_map_.end()) {
     return Event::DEFAULT_EV_HANDLE;
   }
-  return name_handle_map_[name];
+  return p->second;
 }
 
 bool EventManager::Has(const std::string& name) {

diff --git a/myframe/event_manager.h b/myframe/event_manager.h
@@ -30,20 +30,22 @@ class EventManager final {
   template<typename T>
   std::shared_ptr<T> Get(ev_handle_t h) {
     std::shared_lock<std::shared_mutex> lk(rw_);
-    if (evs_.find(h) == evs_.end()) {
+    auto p = evs_.find(h);
+    if (p == evs_.end()) {
       return nullptr;
     }
-    return std::dynamic_pointer_cast<T>(evs_[h]);
+    return std::dynamic_pointer_cast<T>(p->second);
   }
 
   template<typename T>
   std::shared_ptr<T> Get(const std::string& name) {
     std::shared_lock<std::shared_mutex> lk(rw_);
-    if (name_handle_map_.find(name) == name_handle_map_.end()) {
+    auto p = name_handle_map_.find(name);
+    if (p == name_handle_map_.end()) {
       return nullptr;
     }
     lk.unlock();
-    return Get<T>(name_handle_map_[name]);
+    return Get<T>(p->second);
   }
 
   bool Has(const std::string& name);