This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrajath
commented
Apr 4, 2024
0xrajath
commented
Apr 4, 2024
AustinGreen
reviewed
Apr 4, 2024
AustinGreen
reviewed
Apr 4, 2024
AustinGreen
reviewed
Apr 4, 2024
@AustinGreen Thoughts on renaming this to Llama Account Multi Call module? That's essentially what this is at the end of the day. We could then just have this as a generalized account multicall setup that can be used for any purpose that needs the account to call directly. |
I've gone ahead and done this. |
0xrajath
commented
Apr 12, 2024
0xrajath
commented
Apr 12, 2024
0xrajath
commented
Apr 12, 2024
0xrajath
commented
Apr 12, 2024
AustinGreen
reviewed
Apr 12, 2024
AustinGreen
reviewed
Apr 12, 2024
AustinGreen
reviewed
Apr 12, 2024
Coverage after merging rajath/rewards-claim into main will be
Coverage Report
|
AustinGreen
approved these changes
Apr 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need a Rewards Claimer that allows multiple rewards to be claimed with the Llama account as the caller.
This can be achieved through a generic
Account Multicall
module.Modifications:
LlamaAccountMulticallFactory
- To deploy the account multicall modules.LlamaBaseAccountExtension
- Base Account Extension contract withonlyDelegateCall
modifierLlamaAccountMulticallGuard
- Guard on top of Llama Account's execute function.LlamaAccountMulticallExtension
- A multicall extension for the Llama Account with authorized targets and selectorsLlamaAccountMulticallStorage
- Account Multicall Storage contract (To prevent storage collision with Llama Account while being delegate-called)Result:
Account Multicall
module.Gas Report:
forge test --match-test=test_Multicall --gas-report