Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

feat: add bySignature methods for action creating and casting #14

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

dd0sxx
Copy link
Contributor

@dd0sxx dd0sxx commented Dec 5, 2023

Motivation:

Adds bySignature methods to the token voting caster and action creator. This allows tokenholders to create actions and vote by only using a signature. This PR also includes the forge-std and open-zeppelin submodules.

Modifications:

This abstracts casting and creating logic into internal functions that are used directly by an external function on the contract or through a bySig function that takes a signature.

Result:

Users can call the common tokenvoting functions by signature.

@AustinGreen AustinGreen changed the title feat: bySignature methods feat: add bySignature methods for action creating and casting Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

Coverage after merging theo/bysig into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/lib
   ERC721NonTransferableMinimalProxy.sol0%0%0%0%102, 104, 106, 118–120, 128, 128, 128, 130, 130, 130, 134, 137, 139, 143, 145, 145, 145, 149, 152, 154, 156, 164, 166, 166, 166, 175, 177, 177, 177, 190, 41, 41, 41, 45, 45, 45, 47, 63–64, 72, 74, 74, 74, 76, 78, 82, 84, 88, 88, 88, 90, 90, 90, 92, 92, 92, 97, 99
   LlamaUtils.sol0%0%0%0%13, 13, 13–14, 19, 19, 19–20, 26, 32
   PolicyholderCheckpoints.sol0%0%0%0%101–102, 110, 123, 125, 125, 125, 127, 130, 130, 130, 133, 133, 133–136, 138, 140, 142–143, 160–162, 162, 162–163, 165, 168, 184–186, 186, 186–187, 189, 192, 202, 211, 222, 229, 229–231, 233, 233–235, 237, 237–239, 241, 241–243, 262, 265–271, 278, 38, 38, 38–39, 41, 43–44, 46, 46, 46–48, 48, 48–49, 51, 55, 57, 72, 79–80, 97–98, 98, 98–99
   SupplyCheckpoints.sol0%0%0%0%100–101, 109, 124, 126, 126, 126, 128, 131, 131, 131, 134, 134, 134–137, 139, 142, 159–161, 161, 161–162, 164, 167, 183–185, 185, 185–186, 188, 191, 201, 210, 213, 215–216, 224, 235, 242, 242–244, 246, 246–248, 250, 250–252, 254, 254–256, 275, 278–284, 291, 42, 42, 42–43, 45, 47–48, 50, 50, 50–52, 52, 52–53, 55, 59, 61, 71, 78–79, 96–97, 97, 97–98
src/token-voting
   ERC20TokenholderActionCreator.sol0%100%0%0%25, 29, 33
   ERC20TokenholderCaster.sol0%100%0%0%24, 28, 32
   ERC721TokenholderActionCreator.sol0%100%0%0%28, 32, 36
   ERC721TokenholderCaster.sol0%100%0%0%24, 28, 32
   LlamaTokenVotingFactory.sol0%0%0%0%47–48, 48, 48–50, 52–53, 65–66, 73–74, 84–85, 95–96
   TokenholderActionCreator.sol0%0%0%0%125, 154–156, 156, 156–157, 164, 177–179, 179, 179–180, 187, 187, 187–188, 188, 188–189, 197, 210–211, 211, 211–212, 215–216, 216, 216, 218, 220–221, 225–226, 230, 230, 230–232, 242–243, 250, 270, 272, 286, 295, 299, 304
   TokenholderCaster.sol0%0%0%0%211, 223–225, 225, 225–226, 238, 250–252, 252, 252–253, 260, 262, 262, 262, 264–265, 265, 265–266, 269, 269, 269, 272–273, 273, 273–274, 277–282, 282, 282–283, 283, 283, 285–287, 294, 296–297, 297, 297, 299, 301, 301, 301–302, 304, 304, 304, 306–307, 307, 307–308, 311–316, 316, 316–317, 317, 317, 319–321, 327, 329–330, 330, 330–331, 331, 331–332, 332–335, 337, 339–340, 342, 342, 342–343, 343, 343–344, 344, 344–346, 352, 354–355, 355, 355–356, 356, 356–357, 357, 357–358, 358–361, 363, 365–366, 368, 368, 368–369, 369, 369–370, 370, 370–372, 376, 376, 376, 379–380, 380, 380–381, 384, 384, 384, 392, 402–403, 410, 425, 436, 447, 458, 463

@AustinGreen AustinGreen merged commit 9d94c69 into main Dec 5, 2023
3 of 5 checks passed
@AustinGreen AustinGreen deleted the theo/bysig branch December 5, 2023 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants