Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

test: by signature tests #21

Merged
merged 7 commits into from
Dec 8, 2023
Merged

test: by signature tests #21

merged 7 commits into from
Dec 8, 2023

Conversation

dd0sxx
Copy link
Contributor

@dd0sxx dd0sxx commented Dec 7, 2023

Motivation:

  • importing over the by signature tests so that the token voting module supports creating/canceling/approving/disapproving actions by signature

Modifications:

  • Added the tests over from llama-internal and adjusted them to work in llama-periphery

Result:

We now have tests for all of the by signature methods in the token voting module

Copy link

github-actions bot commented Dec 7, 2023

Coverage after merging theo/by-sig-tests into main will be

93.59%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/token-voting
   ERC20TokenholderActionCreator.sol100%100%100%100%
   ERC20TokenholderCaster.sol100%100%100%100%
   ERC721TokenholderActionCreator.sol0%100%0%0%27, 31, 35
   ERC721TokenholderCaster.sol0%100%0%0%24, 28, 32
   LlamaTokenVotingFactory.sol100%100%100%100%
   TokenholderActionCreator.sol92.54%92.86%82.35%97.22%211–212
   TokenholderCaster.sol93.60%91.67%83.33%96.81%273–274, 307–308, 355–356, 380–381

@AustinGreen AustinGreen merged commit 962e579 into main Dec 8, 2023
4 of 5 checks passed
@AustinGreen AustinGreen deleted the theo/by-sig-tests branch December 8, 2023 01:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants