Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

refactor: deployments decoupled from LlamaExecutor #25

Merged
merged 28 commits into from
Dec 10, 2023

Conversation

dd0sxx
Copy link
Contributor

@dd0sxx dd0sxx commented Dec 8, 2023

Motivation:

Closes #8

Modifications:

  • Added a LlamaCore type argument to the deployTokenVotingModule function, so that anyone can deploy a token voting module and not just an instance's executor.
  • We should note that now anyone can deploy this module with a core instance they don't own and any token. it can't do anything unless given a policy, but someone could try to deploy a duplicate and pass in the wrong address etc so we should be careful when inspecting the addresses.

Result:

#8 is closed and tokenvoting deployments are decoupled from the LlamaExecutor

Base automatically changed from rajath/minimal-proxies to main December 9, 2023 15:56
0xrajath
0xrajath previously approved these changes Dec 9, 2023
AustinGreen
AustinGreen previously approved these changes Dec 9, 2023
@dd0sxx dd0sxx dismissed stale reviews from AustinGreen and 0xrajath via 4ed9a29 December 9, 2023 21:44
@dd0sxx dd0sxx marked this pull request as ready for review December 9, 2023 21:44
Copy link

github-actions bot commented Dec 9, 2023

Coverage after merging theo/tv-deployments-decoupled-from-executor into main will be

97.38%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/token-voting
   ERC20TokenholderActionCreator.sol87.50%50%100%100%37–38
   ERC20TokenholderCaster.sol92.31%50%100%100%39
   ERC721TokenholderActionCreator.sol84.21%50%100%100%37, 39–40
   ERC721TokenholderCaster.sol91.67%50%100%100%39
   LlamaTokenVotingFactory.sol100%100%100%100%
   TokenholderActionCreator.sol90.91%83.33%83.33%97.56%117–118, 223–224
   TokenholderCaster.sol91.58%86.76%84.21%96.12%197–201, 281–282, 315–316, 363–364, 388–389

@AustinGreen AustinGreen merged commit a32ec25 into main Dec 10, 2023
5 checks passed
@AustinGreen AustinGreen deleted the theo/tv-deployments-decoupled-from-executor branch December 10, 2023 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove requirement that token voting contracts must be deployed from instance's executor
3 participants