This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
refactor: changed language to reflect governors rather than llama #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging theo/governor-language into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
0xrajath
reviewed
Dec 9, 2023
| @@ -23,7 +23,7 @@ contract ERC20TokenholderActionCreator is TokenholderActionCreator { | |||
| /// The `initializer` modifier ensures that this function can be invoked at most once. | |||
| /// @param _token The ERC20 token to be used for voting. | |||
| /// @param _llamaCore The `LlamaCore` contract for this Llama instance. | |||
| /// @param _role The role used by this contract to cast approvals and disapprovals. | |||
| /// @param _role The role used by this contract to cast approvals and vetos. | |||
There was a problem hiding this comment.
There is still approval here. I'm assuming that should be votes?
There was a problem hiding this comment.
And I can see it's still approvals in a bunch of other places. Might want to do a quick search and replace and confirm if the changes look good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
closes #1
Modifications:
Result:
the languaged used will be more familiar to governor users