Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

chore: lock submodule dependencies to specific commit hashes #37

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

AustinGreen
Copy link
Contributor

Motivation:

Locking in submodule dependencies ensures that forge install will be reproducible.

Modifications:

Submodule commit hashes are added to .gitmodules. The commit hash of the most recent release was used for all dependencies.

Result:

Closes #15

Copy link

Coverage after merging austin/hardcode-submodules into main will be

97.40%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/token-voting
   ERC20TokenholderActionCreator.sol87.50%50%100%100%37–38
   ERC20TokenholderCaster.sol92.31%50%100%100%39
   ERC721TokenholderActionCreator.sol84.21%50%100%100%37, 39–40
   ERC721TokenholderCaster.sol91.67%50%100%100%39
   LlamaTokenVotingFactory.sol100%100%100%100%
   TokenholderActionCreator.sol90.91%83.33%83.33%97.56%117–118, 223–224
   TokenholderCaster.sol91.58%86.76%84.21%96.12%197–201, 281–282, 315–316, 363–364, 388–389

@AustinGreen AustinGreen merged commit 09c6e1c into main Dec 10, 2023
5 checks passed
@AustinGreen AustinGreen deleted the austin/hardcode-submodules branch December 10, 2023 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should hardcode submodule commits like we do in the main repo
2 participants