Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

fix: EIP-712 fixes #64

Merged
merged 3 commits into from
Dec 14, 2023
Merged

fix: EIP-712 fixes #64

merged 3 commits into from
Dec 14, 2023

Conversation

0xrajath
Copy link
Contributor

@0xrajath 0xrajath commented Dec 14, 2023

Motivation:

EIP-712 fixes and missing natspec.

Modifications:

  • EIP-712 fixes
  • Missing natspec and wrong natspec corrected.

Result:

Correct EIP-712 hashes

@0xrajath 0xrajath self-assigned this Dec 14, 2023
Copy link

Coverage after merging rajath/eip-712-fixes into main will be

91.63%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/token-voting
   LlamaERC20TokenActionCreator.sol87.50%50%100%100%43–44
   LlamaERC20TokenCaster.sol92.31%50%100%100%43
   LlamaERC721TokenActionCreator.sol84.21%50%100%100%43, 45–46
   LlamaERC721TokenCaster.sol87.50%50%100%100%43, 45
   LlamaTokenActionCreator.sol84.62%68.18%85.71%91.67%125–126, 271, 271–274, 274, 274, 280–281
   LlamaTokenCaster.sol85.97%83.33%82.14%88.43%201–202, 361, 365, 365, 365–367, 367, 367–371, 373, 448, 448–451, 451, 451, 457–458, 463–464
   LlamaTokenVotingFactory.sol100%100%100%100%

@0xrajath 0xrajath merged commit ef33754 into main Dec 14, 2023
5 checks passed
@0xrajath 0xrajath deleted the rajath/eip-712-fixes branch December 14, 2023 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants