This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: added voting delay, configurable delay, voting, and submission periods, and checkpoints for periods #66
feat: added voting delay, configurable delay, voting, and submission periods, and checkpoints for periods #66
Changes from 24 commits
a3d9e07
af9c1ef
2bb3f4e
cbce3da
b48750e
cccded6
8f59376
c16d10e
264218e
228f830
83825c6
66d1bdc
62e48c6
8e06643
69117cf
1550514
aba8341
d2e978c
1f2823f
abe2676
a109d5d
6dd31ff
f028e5f
6960a96
84b362f
448bc49
3a4c010
88946da
a000c44
4eaf6a1
0d50295
8e546f6
ddd9839
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can bump this up right to fill the entire word. I know it makes no difference to the actual Pct, but if I remember right it's cheaper to access a full word (i.e 256) vs less than that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we can leave it as is if we want to be consistent on using
uint16
for Percentages everywhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uint16 makes the most sense because the max value is 10000 anyways and uint8 is not enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's let the auditors golf this i don't think we should worry about that in this pr