Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

refactor: caster initializes with caster config #69

Closed
wants to merge 40 commits into from

Conversation

dd0sxx
Copy link
Contributor

@dd0sxx dd0sxx commented Dec 15, 2023

Motivation:

closes #68

Modifications:

  • created CasterConfig struct
  • Pass in the config at initialization time for the caster contracts

Result:

periods can be set at deploy time

Copy link

Coverage after merging theo/caster-config into main will be

88.38%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/token-voting
   LlamaERC20TokenActionCreator.sol87.50%50%100%100%43–44
   LlamaERC20TokenCaster.sol92.31%50%100%100%42
   LlamaERC721TokenActionCreator.sol84.21%50%100%100%43, 45–46
   LlamaERC721TokenCaster.sol87.50%50%100%100%42, 44
   LlamaTokenActionCreator.sol84.62%68.18%85.71%91.67%125–126, 271, 271–274, 274, 274, 280–281
   LlamaTokenCaster.sol81.61%79.27%78.13%83.67%208–209, 402, 407, 407, 407–409, 409, 409–413, 415, 433, 442, 442, 442–444, 444, 444–448, 450, 534–535, 543, 543–546, 546, 546, 552–553, 558–559
   LlamaTokenVotingFactory.sol100%100%100%100%

@dd0sxx dd0sxx closed this Dec 15, 2023
@AustinGreen AustinGreen deleted the theo/caster-config branch January 11, 2024 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass in PeriodPcts at deploy time.
2 participants