This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
feat: create happy path for default token support #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR feels unnecessary IMO. It's sort of making things more complicated by introducing a new flow. I actually like the fact that we have to have a tokenAdapter for everything (it's very simple to reason about) instead about having to keep track of when a token adapter is needed or not. |
|
Yeah I agree after discussing. Going to close this and provide context in #75 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This PR allows deployers to specify their tokenAdapter address to the zero address and instruct the creator and caster to call the token contract directly. This is only possible for tokens that implement
IVotesandIERC6372.Modifications:
Add token to the factory deploy parameters and define internal functions that either call the token directly or use the tokenAdapter.
Result:
We'll have default support for tokens that implement
IVotesandIERC6372.