Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nginx with all local versions #56

Merged
merged 2 commits into from
Jun 20, 2021
Merged

use nginx with all local versions #56

merged 2 commits into from
Jun 20, 2021

Conversation

wwick
Copy link
Member

@wwick wwick commented Jun 6, 2021

No description provided.

@wwick wwick requested a review from justinrporter June 6, 2021 18:50
Copy link
Contributor

@justinrporter justinrporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question: are local-stupoli.yml and local-umkc.yml intended to be production? I ask since they're using port 80 and don't have the selenium VM.

@wwick
Copy link
Member Author

wwick commented Jun 7, 2021

Just one question: are local-stupoli.yml and local-umkc.yml intended to be production? I ask since they're using port 80 and don't have the selenium VM.

They're not intended to be production. My thought was that it's unnecessary to start the selenium server if you just want to view LLEMR with those sites' settings, and this helps us not repeat ourselves too much. I think they're using 8000, not 80.

@bjubes
Copy link
Member

bjubes commented Jun 13, 2021

Did you check that changes in JS and CSS files apply when refreshing in the browser? I know this doesn't work using the production config changes I made in #50, but wouldn't want to lose that for local configs

@wwick wwick merged commit 6fe8e60 into master Jun 20, 2021
@justinrporter justinrporter deleted the nginx-all-versions branch June 21, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants