Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#128) instruction: freeze #137

Merged
merged 4 commits into from
Apr 15, 2020
Merged

(#128) instruction: freeze #137

merged 4 commits into from
Apr 15, 2020

Conversation

dannypsnl
Copy link
Member

@dannypsnl dannypsnl commented Apr 14, 2020

TODO:

  • update submodule ll once PR merged.

TODO: update submodule ll once PR merged.
@dannypsnl dannypsnl requested a review from mewmew April 14, 2020 12:06
Copy link
Member

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @dannypsnl! It's basically perfect. I only made a few suggestions to keep the code base consistent.

Copy link
Member

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed an issue with freeze instruction that would give the error unable to locate local identifier "%x" of "@f", for the following LLVM IR:

define void @f(i32 %x) {
entry:
	add i32 %x, 42 ; works
	freeze i32 %x  ; fails
	ret void
}

@mewmew
Copy link
Member

mewmew commented Apr 14, 2020

Hi @dannypsnl.

Glad you started this work. If anything in the review seem strange, just ping me on Discord and we can discuss :)

Cheers,
Robin

dannypsnl and others added 3 commits April 15, 2020 14:24
These suggestions are obviously correct. The rest of suggestions I would take a look at tonight.

Co-Authored-By: Robin Eklind <[email protected]>
@dannypsnl
Copy link
Member Author

Noticed an issue with freeze instruction that would give the error unable to locate local identifier "%x" of "@f", for the following LLVM IR:

define void @f(i32 %x) {
entry:
	add i32 %x, 42 ; works
	freeze i32 %x  ; fails
	ret void
}

This won't happen now, I already check output IR. Therefore, @mewmew you can check PR again. BTW, should we make a release for LLVM 10.0 supporting?

@dannypsnl dannypsnl requested a review from mewmew April 15, 2020 10:27
Copy link
Member

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@mewmew mewmew merged commit 82f819b into llir:master Apr 15, 2020
@mewmew
Copy link
Member

mewmew commented Apr 15, 2020

This won't happen now, I already check output IR. Therefore, @mewmew you can check PR again.

Merged :)

BTW, should we make a release for LLVM 10.0 supporting?

Definitely! I think we should prepare the last few things and then do a release of llir/llvm will LLVM 10.0 support.

I seems most larger concepts are now complete, the only thing remaining is e.g. new enum values?

Edit: I moved the comment below to #128 (comment) to keep track of it better.

@dannypsnl dannypsnl deleted the 128/inst-freeze branch April 15, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants