-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#128) instruction: freeze #137
Conversation
TODO: update submodule ll once PR merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @dannypsnl! It's basically perfect. I only made a few suggestions to keep the code base consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed an issue with freeze instruction that would give the error unable to locate local identifier "%x" of "@f"
, for the following LLVM IR:
define void @f(i32 %x) {
entry:
add i32 %x, 42 ; works
freeze i32 %x ; fails
ret void
}
Hi @dannypsnl. Glad you started this work. If anything in the review seem strange, just ping me on Discord and we can discuss :) Cheers, |
These suggestions are obviously correct. The rest of suggestions I would take a look at tonight. Co-Authored-By: Robin Eklind <[email protected]>
This won't happen now, I already check output IR. Therefore, @mewmew you can check PR again. BTW, should we make a release for LLVM 10.0 supporting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Merged :)
Definitely! I think we should prepare the last few things and then do a release of I seems most larger concepts are now complete, the only thing remaining is e.g. new enum values? Edit: I moved the comment below to #128 (comment) to keep track of it better. |
TODO: