Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#147) DIModule #157

Merged
merged 5 commits into from
Nov 11, 2020
Merged

(#147) DIModule #157

merged 5 commits into from
Nov 11, 2020

Conversation

dannypsnl
Copy link
Member

@dannypsnl dannypsnl commented Nov 7, 2020 •
edited
Loading

mewmew
mewmew reviewed Nov 8, 2020
View reviewed changes
Copy link
Member

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one minor comment. md.Line may have to be allocated before assigned?

@dannypsnl
Copy link
Member Author

dannypsnl commented Nov 8, 2020 •
edited
Loading

Notice some tests would fail since we haven't update testdata, @mewmew would you like to update that? I thought we could also find out some missing cases just like the last time.

@mewmew
Copy link
Member

mewmew commented Nov 8, 2020

Notice some tests would fail since we haven't update testdata, @mewmew would you like to update that? I thought we could also find out some missing cases just like the last time.

Done. Test cases have now been updated to LLVM 11.0. Created issue #158 to track the progress.

Cheers,
Robin

@mewmew mewmew merged commit 0a6e240 into master Nov 11, 2020
@dannypsnl dannypsnl deleted the llvm11-dimodule branch November 16, 2020 06:08
@mewmew mewmew mentioned this pull request Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewmew mewmew mewmew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannypsnl @mewmew