WIP: Implement streaming completions #32
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x1eef
reviewed
Nov 8, 2024
lib/llm/response/chunk.rb
Outdated
| # frozen_string_literal: true | ||
|
|
||
| module LLM | ||
| class Response::Chunk < Response |
There was a problem hiding this comment.
Should we inherit from Response::Completion ? It is still a Completion response, right ?
There was a problem hiding this comment.
It certainly is, I was thinking about it, but got a little hesitant.
| @@ -30,8 +30,18 @@ def complete(message, **params) | |||
| params = DEFAULT_PARAMS.merge(params) | |||
| body = {messages: messages.map(&:to_h)}.merge!(params) | |||
| req = preflight(req, body) | |||
| res = request(@http, req) | |||
| Response::Completion.new(res.body, self).extend(response_parser) | |||
| if params[:stream] | |||
There was a problem hiding this comment.
We could offload the complexity to another method
stream!(req, body) if params[:stream]
stream_completion!(req, body) if params[:stream]There was a problem hiding this comment.
@0x1eef I'm still not sure about we go about this
antaz
changed the title
0x1eef
reviewed
Nov 8, 2024
lib/llm/response/chunk.rb
Outdated
| # frozen_string_literal: true | ||
|
|
||
| module LLM | ||
| require_relative "completion" |
There was a problem hiding this comment.
Can we move this to lib/llm/response.rb instead ? The require_relative statements found in that file are properly ordered. For example, it could be like this and the dependencies should be properly met:
require "json"
require_relative "response/completion"
require_relative "response/chunk"
require_relative "response/embedding"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Chunkresponse to represent a streamed completion chunkExamples