Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMT] Add push/pop operations #7865

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[SMT] Add push/pop operations #7865

merged 2 commits into from
Nov 22, 2024

Conversation

TaoBi22
Copy link
Contributor

@TaoBi22 TaoBi22 commented Nov 21, 2024

Adds push and pop ops to add/remove assertions from the assertion stack as per SMTLIB.

Unfortunately SMTLIB specifies that each of them takes a number of levels to push/pop but the Z3 API only provides such an argument for pop, so we have to make multiple calls for a big push (but I can't imagine that this will ever really be used in practice).

@TaoBi22 TaoBi22 requested a review from maerhart as a code owner November 21, 2024 17:04
Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A short integration test exercising the Z3 calls might be nice. But otherwise this looks fantastic! 🎉

@TaoBi22
Copy link
Contributor Author

TaoBi22 commented Nov 22, 2024

A short integration test exercising the Z3 calls might be nice.

Good point! Added now, thanks!

@TaoBi22 TaoBi22 merged commit 9cdbccf into llvm:main Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants