Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Clarify that ffile-prefix-map applies to fcoverage-prefix-map, too [NFC] #117135

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Nov 21, 2024

No description provided.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Nov 21, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 21, 2024

@llvm/pr-subscribers-clang

Author: None (maflcko)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/117135.diff

1 Files Affected:

  • (modified) clang/include/clang/Driver/Options.td (+1-1)
diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index 5167c3c39e315a..01a3ad0943b4cc 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -4405,7 +4405,7 @@ def fcoverage_prefix_map_EQ
     HelpText<"remap file source paths <old> to <new> in coverage mapping. If there are multiple options, prefix replacement is applied in reverse order starting from the last one">;
 def ffile_prefix_map_EQ
   : Joined<["-"], "ffile-prefix-map=">, Group<f_Group>,
-    HelpText<"remap file source paths in debug info, predefined preprocessor "
+    HelpText<"remap file source paths in debug info, coverage mapping, predefined preprocessor "
              "macros and __builtin_FILE(). Implies -ffile-reproducible.">;
 def fmacro_prefix_map_EQ
   : Joined<["-"], "fmacro-prefix-map=">, Group<f_Group>,

@maflcko
Copy link
Contributor Author

maflcko commented Nov 21, 2024

I think this was just forgotten when the option was introduced initially in c332445 (under a different name)

@maflcko maflcko requested a review from keith November 21, 2024 11:29
@maflcko maflcko merged commit 994c544 into llvm:main Nov 22, 2024
10 checks passed
@keith
Copy link
Member

keith commented Nov 22, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants