Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb][test] DW_OP_piece-O3.c: Disable on Windows #117355

Merged

Conversation

kuilpd
Copy link
Contributor

@kuilpd kuilpd commented Nov 22, 2024

@llvmbot
Copy link
Member

llvmbot commented Nov 22, 2024

@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-platform-windows

@llvm/pr-subscribers-backend-aarch64

Author: Ilia Kuklin (kuilpd)

Changes

#117168


Full diff: https://github.com/llvm/llvm-project/pull/117355.diff

1 Files Affected:

  • (modified) lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c (+2-1)
diff --git a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
index 77ea81f30395f0..50d13e446d539f 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
+++ b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
@@ -5,9 +5,10 @@
 //                 DW_AT_type      (0x00000032 "char[5]")
 //                 DW_AT_location  (DW_OP_piece 0x2, DW_OP_addrx 0x0, DW_OP_piece 0x1)
 
+// XFAIL: target=aarch64-pc-windows-{{.*}}
 // RUN: %clang_host -O3 -gdwarf %s -o %t
 // RUN: %lldb %t \
-// RUN:   -o "b 25" \
+// RUN:   -o "b 26" \
 // RUN:   -o "r" \
 // RUN:   -o "p/x array[2]" \
 // RUN:   -b | FileCheck %s

@@ -5,9 +5,10 @@
// DW_AT_type (0x00000032 "char[5]")
// DW_AT_location (DW_OP_piece 0x2, DW_OP_addrx 0x0, DW_OP_piece 0x1)

// XFAIL: target=aarch64-pc-windows-{{.*}}
Copy link
Contributor

@luporl luporl Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to just skip the test on windows:
// UNSUPPORTED: system-windows

At least on AArch64, debug info doesn't work with -O3 -gdwarf.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you, good to know!

@kuilpd kuilpd changed the title [lldb][test] DW_OP_piece-O3.c: XFAIL on AArch64 Windows [lldb][test] DW_OP_piece-O3.c: Disable on Windows Nov 22, 2024
Copy link
Contributor

@luporl luporl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the failure for WoA, thanks.

@kuilpd kuilpd merged commit 4be09f0 into llvm:main Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants