Add Apple M4 host detection #117530
Open
Add Apple M4 host detection #117530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
commented
Nov 25, 2024
Comment on lines
+1508
to
+1511
| case CPUFAMILY_UNKNOWN: | ||
| return "invalid"; |
There was a problem hiding this comment.
Unsure if I should return "generic" or "invalid" when the host CPU cannot be detected?
There was a problem hiding this comment.
should be "generic", or perhaps change sys::getHostCPUName() to return a std::optional<StringRef>
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
madsmtm
force-pushed
the
apple-m4-host-detection
branch
from
7944594
to
82bd606
Compare
madsmtm
force-pushed
the
apple-m4-host-detection
branch
from
82bd606
to
6074a26
Compare
Also add support for older ARM families (this is likely never going to get used, since only macOS is officially supported as host OS, but nice to have for completeness sake). Error handling (checking CPUFAMILY_UNKNOWN) is also included here. Finally, add links to extra documentation to make it easier for others to update this in the future. These values should be up to date with Xcode 16.2 beta 3.
madsmtm
force-pushed
the
apple-m4-host-detection
branch
from
6074a26
to
7b5d723
Compare
jroelofs
reviewed
Nov 28, 2024
| // | ||
| // NOTE: We choose to return `apple-mX` instead of `apple-aX`, since the M1, | ||
| // M2, M3 etc. aliases are more widely known to users than A14, A15, A16 etc. | ||
| // (and this code is basically only used on host macOS anyways). |
There was a problem hiding this comment.
From that perspective, I think it only makes sense to include the ones that shipped in a Mac. All the others are effectively dead code.
jroelofs
reviewed
Nov 28, 2024
| case CPUFAMILY_ARM_TAHITI: | ||
| return "apple-m4"; // A18 Pro | ||
| case CPUFAMILY_ARM_TUPAI: | ||
| return "apple-m4"; // A18 |
There was a problem hiding this comment.
Mind combining these with fallthroughs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Apple M4 host detection, which fixes rust-lang/rust#133414.
Also add support for older ARM families (this is likely never going to get used, since only macOS is officially supported as host OS, but nice to have for completeness sake). Error handling (checking
CPUFAMILY_UNKNOWN) is also included here.Finally, add links to extra documentation to make it easier for others to update this in the future.
NOTE: These values are taken from the Xcode 16.2 Beta 3 SDK, and has been confirmed on an M4 Max in rust-lang/rust#133414 (comment).