Skip to content

Commit

Permalink
[CI] Add extra metadata to windows node pool
Browse files Browse the repository at this point in the history
This patch adds additional metadata to the windows node pool so that running
terraform apply does not force recreation of the node pool everytime, which
is reasonably expensive time wise.
  • Loading branch information
boomanaiden154 committed Jan 26, 2025
1 parent aa15ef9 commit a407fc0
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion premerge/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,12 @@ resource "google_container_node_pool" "llvm_premerge_windows" {
# Windows Defender causes an increase in test times by approximately an
# order of magnitude.
metadata = {
"sysprep-specialize-script-ps1" : "Set-MpPreference -DisableRealtimeMonitoring $true"
"sysprep-specialize-script-ps1" = "Set-MpPreference -DisableRealtimeMonitoring $true"
# Terraform wants to recreate the node pool everytime whe running
# terraform apply unless we explicitly set this.
# TODO(boomanaiden154): Look into why terraform is doing this so we do
# not need this hack.
"disable-legacy-endpoints" = "true"
}
disk_size_gb = 200
}
Expand Down

0 comments on commit a407fc0

Please sign in to comment.