-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Torch Dialect] Add torch.aten.mul.int_float
(required to simplify shape calculation of upsample_nearest2d
)
#3764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I have a few comments, so please take a look and ping me when you'd like to have me re-review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change to the lit test, otherwise lgtm
Co-authored-by: zjgarvey <[email protected]>
…shape calculation of `upsample_nearest2d`) (#3764) As per title. See also [PR](#3750) for `torch.aten.mul.float_int`. --------- Co-authored-by: zjgarvey <[email protected]>
As per title. See also PR for
torch.aten.mul.float_int
.