Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch Dialect] Add torch.aten.mul.int_float (required to simplify shape calculation of upsample_nearest2d) #3764

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

giacs-epic
Copy link
Contributor

As per title. See also PR for torch.aten.mul.float_int.

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have a few comments, so please take a look and ping me when you'd like to have me re-review.

lib/Dialect/Torch/IR/TorchOps.cpp Show resolved Hide resolved
test/Conversion/TorchToArith/basic.mlir Outdated Show resolved Hide resolved
Copy link
Collaborator

@qingyunqu qingyunqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to the lit test, otherwise lgtm

@qingyunqu qingyunqu merged commit 1b8d7e0 into llvm:main Nov 20, 2024
3 checks passed
qingyunqu pushed a commit that referenced this pull request Nov 21, 2024
…shape calculation of `upsample_nearest2d`) (#3764)

As per title. See also
[PR](#3750) for
`torch.aten.mul.float_int`.

---------

Co-authored-by: zjgarvey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants