Add support for the padding variations of conv op #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok to me, will let @vivekkhandelwal1 do a final review and merge. |
|
Hello @vivekkhandelwal1, any thoughts on this PR? Thanks! |
rahuls-cerebras
added a commit
that referenced
this pull request
Jan 3, 2025
This reverts commit c1892de.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConvOp defined with padding = "same"/"valid" produces the padding variant of the op, such as
conv2d.paddingfor 2d convolution. This PR adds these conv variations to torch-mlir registry and a decomposition of these ops toaten.convolutionto be able to go through the different pass pipelines.