Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme : document the Makefile #152

Open
lmangall opened this issue Feb 12, 2024 · 4 comments
Open

readme : document the Makefile #152

lmangall opened this issue Feb 12, 2024 · 4 comments
Assignees
Labels
discussion documentation Improvements or additions to documentation enhancement New feature or request

Comments

@lmangall
Copy link
Owner

@552020 your Makefile is pretty fancy, and useful, and I think that's one of the "knowledge acquired" points that should be in the Readme

@lmangall lmangall added the enhancement New feature or request label Feb 12, 2024
@lmangall lmangall changed the title readme : add something about the Makefile readme : document the Makefile Feb 12, 2024
@552020
Copy link
Collaborator

552020 commented Feb 12, 2024

Feel free to feature it!

What should be in our README in my opinion, should the problem how to use actually MLX, i.e. the problem we had with walls and background. I guess at the beginning we were thinking that we need to push the image (I'm not sure if push is the correct term) to the window everytime we change the image, but as far I understand the library has a sort of event listener that update it automatically. It's the conversation you linked yesterday. I'm also not sure if this behavior is documented in the docs of the mlx library. Eventually we can suggest a modification of the docs: so you would have maybe also your first commit accepted in a open source project!

@552020 552020 added the documentation Improvements or additions to documentation label Feb 12, 2024
@lmangall
Copy link
Owner Author

so you would have maybe also your first commit accepted in a open source project!

It sounds like not being a virgin anymore

Do you have your first ?

The doc for MLX is quite light (maybe intentionnaly) but it is true that this seems to be an essential information

@552020
Copy link
Collaborator

552020 commented Feb 17, 2024

It sounds like not being a virgin anymore

Yes, I add a PR in MLX42 already accepted! I spot a typo it's instead of its! 😀

The doc for MLX is quite light (maybe intentionnaly) but it is true that this seems to be an essential information

Just for me to be clear about it, we are talking about the fact that in MLX42 when you modify an image that you already put to the window the library already update the image in the window without the need of reputting it on the window, and this is the reason why the minimap (as a black background) was behind the walls. It would be anyway another issue than the one discussed in this issue.

@lmangall
Copy link
Owner Author

Yes I was talking about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants