Fix(analytics): HTML element is not the PascalCase component

lmc-eu · Dec 12, 2023 · 4ddf584 · 4ddf584
1 parent 343ab51
commit 4ddf584
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/packages/analytics/src/scanners/__tests__/twigScanner.test.ts b/packages/analytics/src/scanners/__tests__/twigScanner.test.ts
@@ -55,6 +55,16 @@ describe('twigScanner', () => {
       expect(result).toBe('local_component');
     });
 
+    it('should return "local_component" if the nodeName is not in the localComponents array but it is a Component', () => {
+      const nodeName = 'ComponentTest';
+      const localComponents = ['Component1', 'Component2', 'Component3'];
+      const baseComponents = ['BaseComponent1', 'BaseComponent2'];
+
+      const result = twigScanner.determineModuleNameFromComponents(nodeName, localComponents, baseComponents);
+
+      expect(result).toBe('local_component');
+    });
+
     it('should return "@lmc-eu/spirit-web-twig" if the nodeName is in the baseComponents array', () => {
       const nodeName = 'BaseComponent2';
       const localComponents = ['Component1', 'Component2', 'Component3'];
@@ -66,7 +76,7 @@ describe('twigScanner', () => {
     });
 
     it('should return "html_element" if the nodeName is not in the localComponents or baseComponents array', () => {
-      const nodeName = 'UnknownComponent';
+      const nodeName = 'div';
       const localComponents = ['Component1', 'Component2', 'Component3'];
       const baseComponents = ['BaseComponent1', 'BaseComponent2'];
 

diff --git a/packages/analytics/src/scanners/twigScanner.ts b/packages/analytics/src/scanners/twigScanner.ts
@@ -52,14 +52,15 @@ export function determineModuleNameFromComponents(
   localComponents: Array<string>,
   baseComponents: Array<string>,
 ) {
-  if (localComponents.includes(nodeName)) {
-    return 'local_component';
-  }
-
   if (baseComponents.includes(nodeName)) {
     return '@lmc-eu/spirit-web-twig';
   }
 
+  const pascalCaseRegex = /^([A-Z][a-z0-9]+)+$/;
+  if (localComponents.includes(nodeName) || nodeName.match(pascalCaseRegex)) {
+    return 'local_component';
+  }
+
   return 'html_element';
 }