Refactor(web-react): Sort rest props in DropdownTrigger by importance

lmc-eu · Jun 6, 2024 · 6f1e000 · 6f1e000
1 parent 04bdf6a
commit 6f1e000
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/web-react/src/components/Dropdown/DropdownTrigger.tsx b/packages/web-react/src/components/Dropdown/DropdownTrigger.tsx
@@ -21,13 +21,13 @@ export const DropdownTrigger = <T extends ElementType = 'button'>(props: Dropdow
 
   return (
     <Component
+      {...rest} // ⚠️ This is maybe a bug, when component is pass via `elementType` prop, the rest props are passed to the component
+      {...otherProps}
+      {...triggerProps}
       id={id}
-      {...rest}
       ref={triggerRef}
       className={classNames(classProps.trigger, styleProps.className)}
       style={styleProps.style}
-      {...triggerProps}
-      {...otherProps}
     >
       {typeof children === 'function' ? children({ isOpen }) : children}
     </Component>