-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE(web): PaginationItem has the same width as the Pagina… #1393
BREAKING CHANGE(web): PaginationItem has the same width as the Pagina… #1393
Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Please check the commit message to ensure that it is correctly worded and understandable😉 |
aa9a519
to
df459d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
df459d2
to
1825988
Compare
It is good, I can only do nitpicking :) Maybe I would avoid the usage of ButtonLink because, in the web package, there is actually no ButtonLink and in the long term, we plan to deprecate ButtonLink everywhere (which, of course, you couldn't know). But we already have a component called Item, so maybe I would turn the sentence around to something like: But your current version is also understandable and I will leave it up to you :) |
1825988
to
d921d99
Compare
…tionButtonLink in Pagination #DS-1030
Description
Additional context
Issue reference