Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(web-twig): Fix dependency link paths for Docker development #1433

Merged
merged 3 commits into from
May 21, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented May 21, 2024

Description

Not all dependencies in web-twig docker environment was correctly linked to shared volume.

Additional context

Adding Makefile and ignore files out of the lint scope of prettier formatting.

Issue reference

@literat literat requested review from adamkudrna, crishpeen, pavelklibani and a team as code owners May 21, 2024 14:03
@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label May 21, 2024
Copy link

netlify bot commented May 21, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit e7d491d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/664ca9a646ed3f00083be9d4

Copy link

netlify bot commented May 21, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit e7d491d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664ca9a6abaad100083f9ec2
😎 Deploy Preview https://deploy-preview-1433--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented May 21, 2024

Coverage Status

coverage: 75.375% (-4.2%) from 79.544%
when pulling e7d491d on chore/fix-encore-linking
into b9c2935 on main.

@literat literat merged commit ea1b9e8 into main May 21, 2024
29 checks passed
@literat literat deleted the chore/fix-encore-linking branch May 21, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants