BREAKING CHANGE(web-react): Rename height and maxHeight ModalDialog props and enhance them #DS-1134 #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
pavelklibani,
curdaj,
a team and
adamkudrna
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
force-pushed
the
bc/react-modal-custom-height
branch
from
9857a7b to
b5d7170
Compare
literat
reviewed
May 24, 2024
packages/web-react/src/components/Modal/demo/ModalScrollingLongContent.tsx
Outdated
Show resolved
Hide resolved
literat
reviewed
May 24, 2024
packages/web-react/src/components/Modal/useModalDialogStyleProps.ts
Outdated
Show resolved
Hide resolved
literat
reviewed
May 24, 2024
packages/web-react/src/components/Modal/useModalDialogStyleProps.ts
Outdated
Show resolved
Hide resolved
literat
reviewed
May 24, 2024
packages/web-react/src/components/Modal/useModalDialogStyleProps.ts
Outdated
Show resolved
Hide resolved
|
It is looking good. I have only a few suggestions for refactoring. |
crishpeen
force-pushed
the
bc/react-modal-custom-height
branch
from
b5d7170 to
ef91ea2
Compare
adamkudrna
approved these changes
May 28, 2024
packages/codemods/src/transforms/v2/web-react/__testfixtures__/modal-custom-height.output.tsx
Show resolved
Hide resolved
packages/web-react/src/components/Modal/demo/ModalScrollingLongContent.tsx
Show resolved
Hide resolved
packages/web-react/src/components/Modal/demo/ModalScrollingLongContent.tsx
Show resolved
Hide resolved
packages/web-react/src/components/Modal/demo/ModalScrollingLongContent.tsx
Show resolved
Hide resolved
packages/web-react/src/components/Modal/demo/ModalScrollingLongContent.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Modal/demo/ModalScrollingLongContent.tsx
Outdated
Show resolved
Hide resolved
adamkudrna
reviewed
May 28, 2024
…rops and enhance them #DS-1134
crishpeen
force-pushed
the
bc/react-modal-custom-height
branch
from
ef91ea2 to
e0d1c57
Compare
literat
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference