Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web-react): Fix types in Dropdown #DS-1221 #1449

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Fix(web-react): Fix types in Dropdown #DS-1221 #1449

merged 1 commit into from
Jun 3, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented May 29, 2024

Description

Additional context

Issue reference

@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 1d57c04
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/665d7ec0f44a04000865146d
😎 Deploy Preview https://deploy-preview-1449--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label May 29, 2024
@coveralls
Copy link

coveralls commented May 29, 2024 •
edited
Loading

Coverage Status

coverage: 78.63% (-18.3%) from 96.911%
when pulling 1d57c04 on fix/ds-1221-fix-types-Dropdown
into a9e7bd0 on integration/release-v2.

@curdaj curdaj force-pushed the fix/ds-1221-fix-types-Dropdown branch from 66dc715 to 6392dc7 Compare May 29, 2024 13:01
@curdaj curdaj marked this pull request as ready for review May 30, 2024 10:39
@curdaj curdaj requested review from pavelklibani and a team as code owners May 30, 2024 10:39
@curdaj curdaj requested a review from literat May 30, 2024 12:36
@curdaj curdaj force-pushed the fix/ds-1221-fix-types-Dropdown branch from 828d109 to 1d57c04 Compare June 3, 2024 08:28
@curdaj curdaj requested a review from literat June 3, 2024 08:37
literat
literat approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks 👍

@curdaj curdaj merged commit 4c88e55 into integration/release-v2 Jun 3, 2024
13 checks passed
@curdaj curdaj deleted the fix/ds-1221-fix-types-Dropdown branch June 3, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

Assignees

@curdaj curdaj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curdaj @coveralls @literat @pavelklibani