Decision about the experimental code #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
reviewed
Jun 4, 2024
crishpeen
reviewed
Jun 4, 2024
literat
force-pushed
the
docs/decision-experimental-code
branch
from
e790aa1 to
3f0d21d
Compare
crishpeen
reviewed
Jun 13, 2024
crishpeen
reviewed
Jun 13, 2024
packages/web-react/docs/stories/feature-flags/Overview.stories.mdx
Outdated
Show resolved
Hide resolved
packages/web-react/docs/stories/feature-flags/Overview.stories.mdx
Outdated
Show resolved
Hide resolved
packages/web-react/docs/stories/feature-flags/Overview.stories.mdx
Outdated
Show resolved
Hide resolved
packages/web-react/docs/stories/feature-flags/Overview.stories.mdx
Outdated
Show resolved
Hide resolved
packages/web-react/docs/stories/feature-flags/Overview.stories.mdx
Outdated
Show resolved
Hide resolved
literat
force-pushed
the
docs/decision-experimental-code
branch
3 times, most recently
from
9f4727e to
62964e4
Compare
|
@crishpeen Hopefully all fixed and rebased. I read it again and again today, and I hope I have reworded all sentences to fit our usage. |
|
TODO: Link this decision to the existing components. |
crishpeen
reviewed
Jun 18, 2024
literat
force-pushed
the
docs/decision-experimental-code
branch
from
62964e4 to
5fe2b4a
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b4e97dd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
literat
force-pushed
the
docs/decision-experimental-code
branch
from
b4e97dd to
ca29a92
Compare
literat
force-pushed
the
docs/decision-experimental-code
branch
from
49ddf21 to
839d765
Compare
crishpeen
approved these changes
Jun 25, 2024
literat
force-pushed
the
docs/decision-experimental-code
branch
from
839d765 to
3a75309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have tried to document the usage of the
unstable_prefix and made a decision for it.It has been heavily inspired by the https://github.com/carbon-design-system/carbon/blob/5f79664cde29039ca272a4847a5b3c98c97d3e64/docs/experimental-code.md and it is like a rabbit hole. So I have tried to document also the usage of the feature flags and maybe a definition of what is the API and what not.
Additional context
There may be some consideration for the future, for instance, if we need to have some better logic around feature flags in SASS like this one https://github.com/carbon-design-system/carbon/blob/5f79664cde29039ca272a4847a5b3c98c97d3e64/packages/feature-flags/index.scss or have some kind of the FeatureFlags provider in the React like this: https://github.com/carbon-design-system/carbon/tree/5f79664cde29039ca272a4847a5b3c98c97d3e64/packages/react/src/components/FeatureFlags
So any advice is appreciated.
Issue reference