BREAKING CHANGE(web-twig): Remove HeaderDesktopActions color prop in favor of isAtEnd #DS-1059
#1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
added
BC
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani,
a team and
curdaj
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
force-pushed
the
feat/header-isatend
branch
from
0ba662f to
6b6d592
Compare
adamkudrna
approved these changes
Jun 4, 2024
packages/web-react/src/components/Header/useHeaderStyleProps.ts
Outdated
Show resolved
Hide resolved
packages/web/src/scss/components/Header/_HeaderDesktopActions.scss
Outdated
Show resolved
Hide resolved
pavelklibani
approved these changes
Jun 4, 2024
packages/web-react/src/components/Header/HeaderDesktopActions.tsx
Outdated
Show resolved
Hide resolved
… `isAtEnd` modifier #DS-1059 See the Header: HeaderDesktopActions Alignment section in the web package Migration Guide to version 2.
… in favor of `isAtEnd` #DS-1059 See the Header: HeaderDesktopActions `isAtEnd` prop section in the web-twig package Migration Guide to version 3.
…in favor of `isAtEnd` #DS-1059 See the Header: HeaderDesktopActions `isAtEnd` prop section in the web-react package Migration Guide to version 2.
crishpeen
force-pushed
the
feat/header-isatend
branch
from
6b6d592 to
1a4ce87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference